Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morning Session P2P Code Review - 03/09/2021 #12

Open
lfmnovaes opened this issue Sep 3, 2021 · 0 comments
Open

Morning Session P2P Code Review - 03/09/2021 #12

lfmnovaes opened this issue Sep 3, 2021 · 0 comments

Comments

@lfmnovaes
Copy link

lfmnovaes commented Sep 3, 2021

Your project looks really good, keep it up. 😄

I have one suggestion for your project:

  • You can improve your function here with a timeout

function validateForm() {

Like this:

setTimeout(() => { alert.style.visibility = 'hidden'; }, 5000);

So after 5 seconds since you called this function, it going to hide the error/alert message.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant