-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add integration test for aid to join multisig #258
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
=======================================
Coverage 83.82% 83.82%
=======================================
Files 48 48
Lines 4229 4229
Branches 1034 1021 -13
=======================================
Hits 3545 3545
- Misses 656 680 +24
+ Partials 28 4 -24 ☔ View full report in Codecov by Sentry. |
Cross-posting here, I tested this against this PR WebOfTrust/keria#254 and it was successful. Once 'keria:latest' is updated, this test should pass. |
Also, if we were to pull WebOfTrust/keria@caad67b and patch 0.1.x of keria, we could merge this without having to upgrade to keria 0.2.x. |
@daviddm if you would like to rerun these checks, KERIA:latest should have the fixes needed: |
5d355c4
to
ccd6aee
Compare
This PR includes multisig test join and illustrates the problem in #227.
The integration test creates a multisig-group with 2 members and threshold 1.
Member 1 adds a new member(member3) to the group and does a double rotation for the new member to be able to join and add the end-role by himself.