add media custom option #4218
Merged
add media custom option #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbuds
reviewed
Jan 9, 2023
|
suggested changes work only in Author Mode |
|
took the liberty of having the selected sound play once (on both author mode when choosing default, and in user mode) |
mrbuds
approved these changes
Jan 9, 2023
Fixes WeakAuras#1102 Signed-off-by: Allen Faure <[email protected]>
Fixes WeakAuras#2598 Signed-off-by: Allen Faure <[email protected]>
|
I pushed two things to this branch now: a) PlaySound playing on the master channel, because that works even if the sound is muted and is something we do for Actions/Conditions b) A bigger rework of how FramTick/TimerTick work. |
Stanzilla
reviewed
Jan 15, 2023
emptyrivers
commented
Jan 15, 2023
| --- @field Notify fun(self: SubscribableObject, event: type, ...: any) | ||
| --- @field HasSubscribers fun(self: SubscribableObject, event: string): boolean | ||
| --- @type SubscribableObject | ||
| local SubscribableObject = |
There was a problem hiding this comment.
unless im mistaken, this feels like it's also some groundwork for #3875?
There was a problem hiding this comment.
Maybe, I'm not actually sure if it will be. It does tick some boxes, but also quite a few things are different from what they would need to be.
For TimerTick sub elements and the region itself now subscribe to the TimerTick event. The first to subscribe/last to unsubscribe causes the region to install/remove an OnUpdate handler. The high priority flag gurantees that the region gets the TimerTick first, even though I'm unsure whether that's actually required, but it keeps the same behaviour. A better system for ordering subscribers will be needed at some point. For FrameTicks the system has now two layers. The base is Private.FrameTick, which if there are any subscribers installs an OnUpdate handler. Each region subscribes to Private.FrameTick if there are subscribers to their FrameTick. Also factor out the code into a separate file.
InfusOnWoW
approved these changes
Jan 15, 2023
|
@emptyrivers any last words? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1102