Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate args when checking authorisation code #17

Open
rmccue opened this issue Jul 1, 2017 · 1 comment
Open

Validate args when checking authorisation code #17

rmccue opened this issue Jul 1, 2017 · 1 comment
Assignees
@almirbi
Labels
Bug

Comments

@rmccue
Copy link
Member

rmccue commented Jul 1, 2017

Tokens\Authorization_Code::validate takes an $args parameter, but we a) don't pass any data in, and b) don't do anything with it. 🙃

Per the spec, we need to validate redirect_uri matched what was passed with the original authorisation request.
@rmccue
Copy link
Member Author

rmccue commented Jul 1, 2017

(Noticed by @tfrommen in #8.)

@rmccue rmccue added the Bug label Jul 1, 2017
@almirbi almirbi self-assigned this Sep 5, 2017
@almirbi almirbi mentioned this issue Sep 5, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@almirbi almirbi

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmccue @almirbi