Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress option to gzip compress files. #85

Open
codenut opened this issue Dec 5, 2015 · 4 comments
Open

Compress option to gzip compress files. #85

codenut opened this issue Dec 5, 2015 · 4 comments

Comments

@codenut
Copy link

codenut commented Dec 5, 2015

Thank you for creating this package! Is it possible to add a compress option that will gzip compress the files that will be uploaded in S3. The use case for this is that s3 doesnt automatically compress javascript,css,etc. assets and it would be nice this option can be added.

'compres' => ['css', 'js']

@Mulkave
Copy link
Member

Mulkave commented Dec 29, 2015

@codenut do you mean to automatically gzip before uploading? And upload the compressed files? We're not talking about minification here though, right?

@codenut
Copy link
Author

codenut commented Dec 30, 2015

@Mulkave yes, that is correct. Just gzip the file before uploading without minification. And also set the ContentEncoding to gzip.

Theres an implementation of it on the repository that I forked.

https://github.com/codenut/cdn/commit/204ffbbb30f249fd437e6422e2fa9e05101b2daa

Thanks!

@Mulkave
Copy link
Member

Mulkave commented Jan 19, 2016

@codenut cool! Can you please open a PR of your implementation?

@uniring
Copy link

uniring commented Apr 6, 2017

+1 for this feature, can someone take a look at @codenut implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants