Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createcanopy #39

Open
5 tasks done
VincyaneBadouard opened this issue Aug 16, 2021 · 1 comment
Open
5 tasks done

createcanopy #39

VincyaneBadouard opened this issue Aug 16, 2021 · 1 comment
Labels

Comments

@VincyaneBadouard
Copy link
Owner

VincyaneBadouard commented Aug 16, 2021

  • code
  • test
  • document (V0)
  • Sylvain's check (code)
  • Geraldine check (doc)
@sylvainschmitt
Copy link
Collaborator

sylvainschmitt commented Aug 16, 2021

I like the graph!

  • I'm not sure either about the name of the function, but I do not have anything else better, so you may ignore that comment
  • Similarly you lack the return in your code, this is a bad habit

Everything else is perfect and the code is very clean short and effective so kudos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants