Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treefromthesky in createcanopy.R #38

Open
5 tasks done
VincyaneBadouard opened this issue Aug 16, 2021 · 1 comment
Open
5 tasks done

treefromthesky in createcanopy.R #38

VincyaneBadouard opened this issue Aug 16, 2021 · 1 comment
Labels
dev

Comments

@VincyaneBadouard
Copy link
Owner

VincyaneBadouard commented Aug 16, 2021 •
edited by GeraldineDerroire
Loading

  • code
  • test
  • document (V0)
  • Sylvain's check (code)
  • Geraldine check (doc)
@VincyaneBadouard VincyaneBadouard changed the title treefromthesky in treefromthesky.R treefromthesky in createcanopy.R Aug 16, 2021
VincyaneBadouard pushed a commit that referenced this issue Aug 16, 2021
createcanopy and treefromthesky functions #38 #39
8bcb7b8
VincyaneBadouard pushed a commit that referenced this issue Aug 16, 2021
createcanopy and treefromthesky functions #38 #39
60b7b8e
@sylvainschmitt
Copy link
Collaborator

sylvainschmitt commented Aug 16, 2021 •
edited by VincyaneBadouard
Loading

  • I do not like the name of the function, I would rather use a sober name (e.g. getwrown). But maybe it's just my point of view and we should discuss with Géraldine. So you can skip this remark.
  • You lack a return in the code. It returns the last object crown but it is always better to define it explicitly.

Everything else is great, congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sylvainschmitt @VincyaneBadouard