Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make iptables setup optional #7

Open
federico-razzoli opened this issue Feb 26, 2021 · 6 comments
Open

Make iptables setup optional #7

federico-razzoli opened this issue Feb 26, 2021 · 6 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@federico-razzoli
Copy link
Member

Setting up Iptables is good (I asked you to do it) but some people prefer to leave all ports open.

I recommend to add a setup_iptables variables, which is true by default, and don't include iptables.yml if it's false.

@federico-razzoli federico-razzoli added the enhancement New feature or request label Feb 26, 2021
@mike-aboagye
Copy link
Contributor

Okay. I will do so. Thanks.

@mike-aboagye
Copy link
Contributor

fixed.

@federico-razzoli
Copy link
Member Author

I reopen this issue because it's not optional. It even has the always tag.

@federico-razzoli federico-razzoli added the bug Something isn't working label Mar 4, 2021
@mike-aboagye
Copy link
Contributor

fixed

@mike-aboagye
Copy link
Contributor

I used the 'iptables' tag instead of the 'always' tag so users can apply the skip-tag option to the tag 'iptables' if they want to leave all ports open.

@federico-razzoli
Copy link
Member Author

This means that one always has to remember to specify that tag. It's not something I'd like to gave on a system I manage.
One should be able to set a variable once, and then forget it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants