Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the test equality for TransformsBase.SequentialTransform #67

Closed
VEZY opened this issue Jun 12, 2024 · 2 comments
Closed

Remove the test equality for TransformsBase.SequentialTransform #67

VEZY opened this issue Jun 12, 2024 · 2 comments

Comments

@VEZY
Copy link
Owner

VEZY commented Jun 12, 2024

We added a method for testing equality in the tests of the package (file test-write_opf.jl) for TransformsBase.SequentialTransform:

Base.:(==)(x::TransformsBase.SequentialTransform, y::TransformsBase.SequentialTransform) = x.transforms == y.transforms

This is added because it uses === by default, which is false, but here we want to compare that the geometries of an OPF that is written and read again have the same geometry.

We should remove that when JuliaML/TransformsBase.jl#8 is fixed, because this is type piracy and it's bad. But anyway we don't export that of course.

Also, we can remove the using TransformsBase in runtests.jl, and remove the package dependency in the test project.

@VEZY
Copy link
Owner Author

VEZY commented Jun 13, 2024

See when JuliaML/TransformsBase.jl#9 is merged and a new version is deployed.

@VEZY
Copy link
Owner Author

VEZY commented Jun 13, 2024

Note: TransformsBase in the v1.5.0 right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant