-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests #17
Conversation
17b1c8d
to
2ef548c
Compare
This should now run "successfully". There seem to be issues using gz sim inside When running our sim_control launchfile, the following processes are started:
So, with this, a gz sim instance keeps running after the test finished. I would rather not merge it this way, but I would also rather much like to have integration tests... |
Since the simulation doesn't shutdown cleanly, we do not want to leave behind a dangling simulation after running a colcon build.
7e10766
to
44f9dc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This aims at fixing #9
The tests in this PR work fine in principle. However, the paremetrization with each robot model seems to lead to a situation where the simulation isn't properly torn down, so for the second tested model there already is a simulation running which prevents the respective simulation from coming up correctly.