Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 17 #186

Open
jiinjoo opened this issue Jan 3, 2022 · 10 comments
Open

Support React 17 #186

jiinjoo opened this issue Jan 3, 2022 · 10 comments

Comments

@jiinjoo
Copy link

jiinjoo commented Jan 3, 2022

React 17 has been released for some 15 months now. Can we add that to the peerDependencies?

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from [email protected]
npm ERR! node_modules/react-image-annotate
npm ERR!   react-image-annotate@"^1.8.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
@jiinjoo
Copy link
Author

jiinjoo commented Jan 20, 2022

Really hoping to help but it's a bit beyond me this maze of dependencies. Some of the underlying dependency upgrades that npm threw at me (even with @HenryLiangzy updates)

  • react-full-screen 0.3.1 needs to go to 1.1.0
  • react-markdown 4.0.6 needs to go to 5, 6, 7, or 8
  • react-monaco-editor 0.25.1 needs to go to 0.47.0 or anything from July 21
  • react-use 13.27.0 needs to go to 17.3.2 (or anything 15 onwards)
  • use-key-hook looks abandoned

@seveibar seveibar pinned this issue Jan 21, 2022
@HenryLiangzy
Copy link
Collaborator

HenryLiangzy commented Jan 25, 2022

Hi @jiinjoo I'm working on it but might need some to time test each dependency, if you are able could you provide more detail on which dependencies need to be updated (besides the library that you mentioned before)? Thanks in advance

@bpw1621
Copy link

bpw1621 commented Mar 2, 2022

Am looking into approaches to integrate image data labeling into an application and this seems perfect for my use-case if it supports React 17: any information on when this might be addressed?

@SalahHaciAkil
Copy link

I have the same problem installing it via npm, I tried installing it using yarn, and it worked

@parthpatel303
Copy link

I am using yarn and having the webpack version issue. Does anyone still working on it? Is there any plan to upgrade to react-script version 5 to support webpack 5 configuration
@seveibar

Screenshot 2022-10-13 at 12 15 43 PM

@seveibar
Copy link
Contributor

Would accept PR :) not a lot of time to actively work on this project

@parthpatel303
Copy link

parthpatel303 commented Oct 14, 2022

@HenryLiangzy Can you please help into this? Thanks!

After installing react-image-annotate, I am getting this error on yarn start

I am using yarn and having the webpack version issue. Does anyone still working on it? Is there any plan to upgrade to react-script version 5 to support webpack 5 configuration @seveibar

Screenshot 2022-10-13 at 12 15 43 PM

@nadavof
Copy link

nadavof commented Jan 4, 2023

Hi,
Any update on this issue?
Thanks,

@SuhaibMaraqa
Copy link

any update to support React 18 ?
Or next.js 13 ?

@Naitikmp
Copy link

Naitikmp commented Oct 4, 2024

can you please update it to support react 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants