Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in results.php can't be made responsive #2

Open
stkdiretto opened this issue Nov 6, 2015 · 6 comments
Open

Images in results.php can't be made responsive #2

stkdiretto opened this issue Nov 6, 2015 · 6 comments

Comments

@stkdiretto
Copy link
Member

So, I tried explicitly making them responsive by using the appropriate tag, which neither worked within the buttons nor the table columns. The old fix of assigning them class='col-xs-12' didn't work either, but resulted in images of varying size. The current workaround is a fixed size that's not too large, which is kind of half-assed.

Any ideas? :(

@onc
Copy link

onc commented Nov 6, 2015

i would take a look at it, but i dont get which images you are talking about... are you talking about the portraits? how should it be?

@stkdiretto
Copy link
Member Author

The portraits on the detail page (not the one with the bargraph, but w/ the detailed results). Ideally, they should resize automatically according to the column width upon resizing the window: right now the complete table always overflows a bit. On the other hand, one candidate has a longer name which might mess up the sizing anyways

@cfritze
Copy link

cfritze commented Nov 6, 2015

<img class="img-responsive" /> is missing
<meta name="viewport" content="width=device-width, initial-scale=1"> is missing

@stkdiretto
Copy link
Member Author

@cfritze it used to be img-responsive (in 39169ce), but the viewport bit is probably the root cause. thanks!

@onc
Copy link

onc commented Nov 6, 2015

the viewport did not work for me. but i noticed different behaviour in chrome compared to firefox.
in chrome the sizes of the images seem to change upon resizing the window, but in firefox not.

take a look at this: https://stackoverflow.com/questions/18846744/responsive-images-in-tables-bootstrap-3

setting width: 100% for img-responsive seems to be right, and the images now take the full width of the column, but i dont like the result...

mahl

@stkdiretto
Copy link
Member Author

yeah, that's what I meant, thats even worse than before ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants