Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open to large-scale refactoring away from params style? #78

Open
jorhett opened this issue Aug 29, 2024 · 1 comment
Open

Open to large-scale refactoring away from params style? #78

jorhett opened this issue Aug 29, 2024 · 1 comment

Comments

@jorhett
Copy link
Contributor

jorhett commented Aug 29, 2024

I personally think that it would be a significant improvement to

  • minimize the use of hardcoded values that change from version to version
  • use modern Hiera data instead of the params.pp style
  • support modern "config-less" slurmd

Are you open to receiving a large-scale refactoring such as this, or should I fork the module if I want to go in that direction?

Agreeing to discuss a refactor != accepting my changes unquestioned, I'm just trying to qualify if you are open to considering it.

@hcartiaux
Copy link
Contributor

Hi @jorhett

That would be awesome, I'm open to the idea and will happily accept PRs. Config-less has been on our todo-list for a long time...

Note that this module was mainly developed by a @Falkor, who left our team 2 years ago, and we do not have the resources to extensively test/develop this module beyond the usual maintenance commits...

On my side, I have testing virtual machines, but I've not maintained the testing workflow based on Vagrant. So if a PR requires a non-trivial change on our production system, I may take time to test/validate.

Best,

Hyacinthe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants