Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation docs: pyCARL builds by default #22

Open
SigmaX opened this issue Dec 16, 2022 · 1 comment
Open

Installation docs: pyCARL builds by default #22

SigmaX opened this issue Dec 16, 2022 · 1 comment

Comments

@SigmaX
Copy link
Contributor

SigmaX commented Dec 16, 2022

Issue

CMakeLists.txt is set to build PyCARL by default when CARLsim is built. This requires PyCARL to be cloned into a specific subdirectory—but these extra installation steps are not reflected in the getting started guide.

Expected Behavior

The installation steps in the user's guide lead to a successful installation.

Observed Behavior

$ cmake -DCMAKE_INSTALL_PREFIX=/home/eric/lib/carlsim6 -DCMAKE_BUILD_TYPE=Release -DGTEST_LIBRARY=~/lib/gtest-1.11/lib/libgtest.so -DGTEST_INCLUDE_DIR=~/lib/gtest-1.11/include/ -DGTEST_MAIN_LIBRARY=~/lib/gtest-1.11/lib/libgtest_main.so -DCARLSIM_NO_CUDA=ON ../.
-- Found GTest: /home/eric/lib/gtest-1.11/lib/libgtest.so  
-- Could NOT find Matlab (missing: Matlab_INCLUDE_DIRS) (found version "NOTFOUND")
CMake Error at CMakeLists.txt:376 (add_subdirectory):
  The source directory

    /home/eric/repos/CARLsim6/pycarl

  does not contain a CMakeLists.txt file.


-- Configuring incomplete, errors occurred!
See also "/home/eric/repos/CARLsim6/.build/CMakeFiles/CMakeOutput.log".

Note

Solution is either to walk through pulling PyCARL in the installation guide, or to recommend that users build with -DCARLSIM_PYCARL=OFF, or change the default value to OFF.

@SigmaX
Copy link
Contributor Author

SigmaX commented May 26, 2023

Situation might have improved a little with with #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant