Make update checker use libcurl and https #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoffeeFlux
reviewed
Dec 3, 2023
| option('enable_update_checker', type: 'boolean', value: false, description: 'Enable the update checker') | ||
| option('update_server', type: 'string', value: 'updates.aegisub.org', description: 'Server to use for the update checker') | ||
| option('enable_update_checker', type: 'boolean', value: true, description: 'Enable the update checker') | ||
| option('update_server', type: 'string', value: 'https://updates.aegisub.org', description: 'Server to use for the update checker') |
There was a problem hiding this comment.
I'll get something stood up here, but just to confirm, did you test this with a different domain on Windows/Mac? Or should I do that on my end?
There was a problem hiding this comment.
Yeah, I tested it with a simple local http server that served some dummy update file (probably sepro's poc file?)
arch1t3cht
force-pushed
the
update_checker
branch
from
fe20d0a
to
8723afb
Compare
The horrible hack with the curl_meson subproject is needed since the libcurl dependency generated by libcurl's cmake build system (via meson's cmake module) includes its internal files its include_directories, which shadows certain other includes. So instead we manually replace the include_directories with the correct ones, taken from a separate meson subproject. This needs an additional wrap file, but it points to the same subproject directory in order to prevent there being multiple downloads of the same libcurl source that could go out of sync at some point. Co-authored-by: sepro <[email protected]>
arch1t3cht
force-pushed
the
update_checker
branch
from
8723afb
to
4d5734f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The horrible hack with the curl_meson subproject is needed since the libcurl dependency generated by libcurl's cmake build system (via meson's cmake module) includes its internal files its include_directories, which shadows certain other includes. So instead we manually replace the include_directories with the correct ones, taken from a separate meson subproject. This needs an additional wrap file, but it points to the same subproject directory in order to prevent there being multiple downloads of the same libcurl source that could go out of sync at some point.