Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-13421 create indexes on sharded sql pumps #861

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

sredxny
Copy link
Contributor

@sredxny sredxny commented Nov 21, 2024

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

pumps/sql.go Outdated Show resolved Hide resolved
pumps/sql.go Outdated Show resolved Hide resolved
pumps/sql.go Outdated Show resolved Hide resolved
pumps/sql.go Outdated Show resolved Hide resolved
}

// waitgroup to facilitate testing and track when all indexes are created
var wg sync.WaitGroup

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need waitgroup when create background is false?

@jeffy-mathew
Copy link

@sredxny since we're using gorm, shall we explore the possibility of using NamingStrategy in gorm config?

@sredxny sredxny enabled auto-merge (squash) December 1, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants