TT-12174 Added support for proxy settings loaded from environment variables #394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
http.ProxyFromEnvironment
to creation of transport for the default client.Description
In the main.go file the
transport
of thehttp.DefaultClient
is overwritten becauseInsecureSkipVerify: config.SSLInsecureSkipVerify
is added. This disables the default behavior of go that the environment variablesHTTP_PROXY
,HTTPS_PROXY
andNO_PROXY
are used for HTTP connections.Related Issue
#393
Motivation and Context
The change allows to use the tyk identity broker to be used in environments where access to external services is managed by a http porxy.
How This Has Been Tested
Patched image used to gain access to a identiy provider via HTTP Proxy
Types of changes
Checklist
fork, don't request your
master
!master
branch (left side). Also, you should startyour branch off our latest
master
.go mod tidy && go mod vendor
go fmt -s
go vet