Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TT-11339: add default port name to values #254

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

TT-11339: add default port name to values #254

wants to merge 2 commits into from

Conversation

olamilekan000
Copy link
Contributor

Description

Change adds a default value for portName is charts values file.

Related Issue

https://tyktech.atlassian.net/browse/TT-11339

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@olamilekan000 olamilekan000 requested a review from a team as a code owner March 27, 2024 10:20
@olamilekan000 olamilekan000 requested review from buraksekili and komalsukhani and removed request for a team and buraksekili March 27, 2024 10:20
@olamilekan000 olamilekan000 force-pushed the TT-11339-set-default-value branch 2 times, most recently from a9b5de5 to 46e3601 Compare May 2, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buraksekili buraksekili Awaiting requested review from buraksekili

@komalsukhani komalsukhani Awaiting requested review from komalsukhani

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olamilekan000 @komalsukhani