TT-10659 feat: Allow disabling scratch volume

[jakub-bochenski]

Description

Add a configuration option to disable mounting a volume onto tyk configuration directories.

Related Issue

Resolves #107

Motivation and Context

See #107

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Refactoring or add test (improvements in base code or adds test coverage to functionality)
• Documentation updates or improvements.

Checklist

• Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
• Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
• My change requires a change to the documentation.
  • I have manually updated the README(s)/documentation accordingly.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[jakub-bochenski]

I've updated the PR to keep the volume only for pid file, as otherwise Tyk would complain it can't write pid file

[jakub-bochenski]

would be nice to get some response here after a month :(

[buraksekili]

@jakub-bochenski sorry for late response - we are at on-site event as a team. i'll raise your request internally too now.

[buraksekili]

can you please check the comments? overall, the pr looks good to me.

[buraksekili]

LGTM. One small comment is that since the gateway component is updated, the umbrella charts (single-dc, mdcb-data-plane, tyk-oss) must be corrected; so that, their values.yaml file also includes the new field introduced in this PR. can you please update it? then, I'll move this ticket to QA. Thank you again for this contribution 🙏

[jakub-bochenski]

Are you sure this is necessary? I think the default values from sub-charts will still be in effect.

Unless you want it there just for visibility

[buraksekili]

You are right - it is not necessary and umbrella charts will be affected as you mentioned.
Just asking for visibility. If someone uses tyk-oss directly, instead of installing tyk-gateway chart directly, it'd be better to have this field also visible in umbrella charts as well.

[jakub-bochenski]

I've added the values to umbrella charts

[buraksekili]

thanks a lot @jakub-bochenski!
i'll forward this ticket to QA and once the testing finished, we can go with releasing this in the upcoming releases

[jakub-bochenski]

@buraksekili @komalsukhani what is the status of this PR?

[caroltyk]

@jakub-bochenski

We have reviewed it and will send for testing for next release. We are tight on resources right now so please expect it to be released in Q1 2024.

Thanks again for your support and contribution!