Skip to content

Commit

Permalink
Improve VO on playerview
Browse files Browse the repository at this point in the history
  • Loading branch information
@GianniCarlo
GianniCarlo committed Nov 15, 2021
1 parent 9da88c7 commit b8f8a70
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 15 deletions.
30 changes: 15 additions & 15 deletions BookPlayer.xcodeproj/project.pbxproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2617,7 +2617,7 @@
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 3;
DEVELOPMENT_TEAM = "$(inherited)";
GCC_C_LANGUAGE_STANDARD = gnu11;
INFOPLIST_FILE = BookPlayerIntents/Info.plist;
Expand Down Expand Up @@ -2651,7 +2651,7 @@
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
CODE_SIGN_IDENTITY = "Apple Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 3;
DEVELOPMENT_TEAM = "$(inherited)";
GCC_C_LANGUAGE_STANDARD = gnu11;
INFOPLIST_FILE = BookPlayerIntents/Info.plist;
Expand Down Expand Up @@ -2683,7 +2683,7 @@
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
CODE_SIGN_IDENTITY = "Apple Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 3;
DEVELOPMENT_TEAM = "$(inherited)";
GCC_C_LANGUAGE_STANDARD = gnu11;
INFOPLIST_FILE = BookPlayerIntents/Info.plist;
Expand Down Expand Up @@ -2719,7 +2719,7 @@
CODE_SIGN_ENTITLEMENTS = BookPlayerWatch/BookPlayerWatch.entitlements;
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 3;
DEVELOPMENT_TEAM = "$(inherited)";
GCC_C_LANGUAGE_STANDARD = gnu11;
IBSC_MODULE = BookPlayerWatch_Extension;
Expand Down Expand Up @@ -2760,7 +2760,7 @@
CODE_SIGN_ENTITLEMENTS = BookPlayerWatch/BookPlayerWatch.entitlements;
CODE_SIGN_IDENTITY = "Apple Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 3;
DEVELOPMENT_TEAM = "$(inherited)";
GCC_C_LANGUAGE_STANDARD = gnu11;
IBSC_MODULE = BookPlayerWatch_Extension;
Expand Down Expand Up @@ -2798,7 +2798,7 @@
CODE_SIGN_ENTITLEMENTS = BookPlayerWatch/BookPlayerWatch.entitlements;
CODE_SIGN_IDENTITY = "Apple Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 3;
DEVELOPMENT_TEAM = "$(inherited)";
GCC_C_LANGUAGE_STANDARD = gnu11;
IBSC_MODULE = BookPlayerWatch_Extension;
Expand Down Expand Up @@ -2834,7 +2834,7 @@
CODE_SIGN_ENTITLEMENTS = "BookPlayerWatch Extension/BookPlayerWatch Extension.entitlements";
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 3;
DEVELOPMENT_TEAM = "$(inherited)";
GCC_C_LANGUAGE_STANDARD = gnu11;
INFOPLIST_FILE = "BookPlayerWatch Extension/Info.plist";
Expand Down Expand Up @@ -2871,7 +2871,7 @@
CODE_SIGN_ENTITLEMENTS = "BookPlayerWatch Extension/BookPlayerWatch Extension.entitlements";
CODE_SIGN_IDENTITY = "Apple Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 3;
DEVELOPMENT_TEAM = "$(inherited)";
GCC_C_LANGUAGE_STANDARD = gnu11;
INFOPLIST_FILE = "BookPlayerWatch Extension/Info.plist";
Expand Down Expand Up @@ -2906,7 +2906,7 @@
CODE_SIGN_ENTITLEMENTS = "BookPlayerWatch Extension/BookPlayerWatch Extension.entitlements";
CODE_SIGN_IDENTITY = "Apple Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 3;
DEVELOPMENT_TEAM = "$(inherited)";
GCC_C_LANGUAGE_STANDARD = gnu11;
INFOPLIST_FILE = "BookPlayerWatch Extension/Info.plist";
Expand Down Expand Up @@ -3065,7 +3065,7 @@
CODE_SIGN_ENTITLEMENTS = BookPlayerWidgetUIExtension.entitlements;
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 3;
DEVELOPMENT_TEAM = "$(inherited)";
GCC_C_LANGUAGE_STANDARD = gnu11;
INFOPLIST_FILE = BookPlayerWidgetUI/Info.plist;
Expand Down Expand Up @@ -3103,7 +3103,7 @@
CODE_SIGN_ENTITLEMENTS = BookPlayerWidgetUIExtension.entitlements;
CODE_SIGN_IDENTITY = "Apple Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 3;
DEVELOPMENT_TEAM = "$(inherited)";
GCC_C_LANGUAGE_STANDARD = gnu11;
INFOPLIST_FILE = BookPlayerWidgetUI/Info.plist;
Expand Down Expand Up @@ -3139,7 +3139,7 @@
CODE_SIGN_ENTITLEMENTS = BookPlayerWidgetUIExtension.entitlements;
CODE_SIGN_IDENTITY = "Apple Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 3;
DEVELOPMENT_TEAM = "$(inherited)";
GCC_C_LANGUAGE_STANDARD = gnu11;
INFOPLIST_FILE = BookPlayerWidgetUI/Info.plist;
Expand Down Expand Up @@ -3285,7 +3285,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "Apple Development";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 3;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEVELOPMENT_TEAM = "$(inherited)";
FRAMEWORK_SEARCH_PATHS = (
Expand Down Expand Up @@ -3320,7 +3320,7 @@
CODE_SIGN_IDENTITY = "Apple Distribution";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "Apple Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 3;
DEVELOPMENT_TEAM = "$(inherited)";
FRAMEWORK_SEARCH_PATHS = (
"$(inherited)",
Expand Down Expand Up @@ -3585,7 +3585,7 @@
CODE_SIGN_IDENTITY = "Apple Distribution";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "Apple Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
CURRENT_PROJECT_VERSION = 3;
DEVELOPMENT_TEAM = "$(inherited)";
FRAMEWORK_SEARCH_PATHS = (
"$(inherited)",
Expand Down
1 change: 1 addition & 0 deletions BookPlayer/Player/Player Screen/PlayerViewController.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ class PlayerViewController: BaseViewController<PlayerCoordinator, PlayerViewMode
self.chapterTitleButton.titleLabel?.numberOfLines = 2
self.chapterTitleButton.titleLabel?.textAlignment = .center
self.chapterTitleButton.titleLabel?.lineBreakMode = .byWordWrapping
self.chapterTitleButton.isAccessibilityElement = false
}

func setupPlayerView(with currentBook: Book) {
Expand Down
3 changes: 3 additions & 0 deletions BookPlayer/Player/Player Screen/Views/ArtworkControl.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ class ArtworkControl: UIView, UIGestureRecognizerDelegate {
self.layer.shadowOpacity = 0.15
self.layer.shadowRadius = 12.0

self.titleLabel.isAccessibilityElement = false
self.authorLabel.isAccessibilityElement = false

self.artworkImage.clipsToBounds = false
// artwork now has the main info regarding the title and author
self.artworkImage.contentMode = .scaleAspectFit
Expand Down

0 comments on commit b8f8a70

Please sign in to comment.