Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

low contrast between ntap & nwell colors #43

Open
mbalestrini opened this issue Feb 10, 2023 · 4 comments
Open

low contrast between ntap & nwell colors #43

mbalestrini opened this issue Feb 10, 2023 · 4 comments

Comments

@mbalestrini
Copy link

The n-tap drawigs inside n-wells are not clearly visible.
It would be good to use another color that makes the n-taps popup a little bit more.

@urish
Copy link
Member

urish commented Feb 11, 2023

Thanks! Any suggestions for a new color? The colors are defined in src/model/layerTypes.ts

@mbalestrini
Copy link
Author

I changed the colors of nwell and substrate and made a pull request: #52
I've included and image so you can check if you like the changes

@urish
Copy link
Member

urish commented Feb 15, 2023

Thanks @mbalestrini! I've had a discussion about this with @mattvenn, and changing the color palette means he'll have to redo the screen shots in the lesson plans.

There's also another change which might affect the color palette at #25 (you can preview it here: https://layer-opacity.siliwiz.pages.dev/).

Therefore, we'd like to have a color palette that includes both your changes and opacity. I don't know if you'd like to work on updating the color palette to include the opacity as well - in case you do, that would be helpful.

@mbalestrini
Copy link
Author

I'll take a look at the opacity idea. I'm not 100% sure about it. I think it might make everything more confuse for someone learning?
I'll try to do some tests in inkscape to see how it might look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants