Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the final shell script as part of distribution #30

Open
alexeagle opened this issue Dec 14, 2020 · 1 comment
Open

Provide the final shell script as part of distribution #30

alexeagle opened this issue Dec 14, 2020 · 1 comment

Comments

@alexeagle
Copy link
Contributor

Right now users copy-paste the bazel-diff-example.sh to stitch together the bazel-diff commands. This means users end up modifying and having diverging copies, not able to upstream their improvements to share with other users.

Ideally some "shrink-wrapped" distribution would include the top-level entry point (maybe still using Bash).

@tinder-maxwellelliott
Copy link
Collaborator

This means users end up modifying and having diverging copies, not able to upstream their improvements to share with other users.

I agree that ideally we could share one shell script to rule them all, the blocker here is that I do not know the exact steps required to build any Bazel project. For example, if we have revision A and revision B there may be a core tooling change that happens in B, that may require the developer to run some kind of setup script before we can run bazel-diff on revision B (think installing some command line tool).

I worry that if we prescribe one approach then users who have some tooling that is not fully specified by Bazel will be left behind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants