Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FailureRatio and SamplingDuration parameters of Polly V8 circuit-breaker #2080

Open
RaynaldM opened this issue May 29, 2024 · 0 comments · May be fixed by #2081
Open

FailureRatio and SamplingDuration parameters of Polly V8 circuit-breaker #2080

RaynaldM opened this issue May 29, 2024 · 0 comments · May be fixed by #2081
Assignees
@RaynaldM
Labels
Autumn'24 Autumn 2024 release Configuration Ocelot feature: Configuration feature A new feature proposal Proposal for a new functionality in Ocelot QoS Ocelot feature: Quality of Service small effort Likely less than a day of development effort.
Milestone
Autumn'24

Comments

@RaynaldM
Copy link
Collaborator

RaynaldM commented May 29, 2024 •
edited
Loading

Add two parameters in QoSOptions:

  • FailureRatio: The failure-success ratio that will cause the circuit to break/open.
  • SamplingDuration: The time period over which the failure-success ratio is calculated (in seconds).

The aim is to take better advantage of Polly's circuit-breaker possibilities, and to manage circuit-break conditions more finely, on a case-by-case basis.

Currently, these 2 parameters are set by default (and in hard coded) with an error ratio of 80% and a sample duration of 10 seconds. These values may not suit everyone.
@RaynaldM RaynaldM added feature A new feature small effort Likely less than a day of development effort. proposal Proposal for a new functionality in Ocelot QoS Ocelot feature: Quality of Service Configuration Ocelot feature: Configuration labels May 29, 2024
@RaynaldM RaynaldM self-assigned this May 29, 2024
RaynaldM added a commit that referenced this issue May 29, 2024
@RaynaldM
#2080 Adds parameters (in this case those of Polly V8) to fine-tune c…
3c125a2 
…ircuit-breaker behavior
@RaynaldM RaynaldM linked a pull request May 29, 2024 that will close this issue
#2080 Add new V8 params to fine-tune Polly's circuit-breaker behavior #2081
Open
@raman-m raman-m changed the title Adds parameters (in this case those of Polly V8) to fine-tune circuit-breaker behavior FailureRatio and SamplingDuration parameters of Polly V8 circuit-breaker May 29, 2024
@raman-m raman-m linked a pull request May 29, 2024 that will close this issue
Open
raman-m pushed a commit that referenced this issue Jun 14, 2024
@RaynaldM @raman-m
#2080 Adds parameters (in this case those of Polly V8) to fine-tune c…
2d2bdaa 
…ircuit-breaker behavior
@raman-m raman-m added Oct'24 October 2024 release 2023 Annual 2023 release and removed Oct'24 October 2024 release labels Jun 16, 2024
@raman-m raman-m added this to the Annual 2023 milestone Jun 16, 2024
@raman-m raman-m added Oct'24 October 2024 release and removed 2023 Annual 2023 release labels Oct 4, 2024
@raman-m raman-m modified the milestones: Annual 2023, October'24 Oct 4, 2024
@raman-m raman-m added Autumn'24 Autumn 2024 release and removed Oct'24 October 2024 release labels Oct 26, 2024
@raman-m raman-m modified the milestones: October'24, Autumn'24 Oct 26, 2024
raman-m pushed a commit that referenced this issue Nov 1, 2024
@RaynaldM @raman-m
#2080 Adds parameters (in this case those of Polly V8) to fine-tune c…
b6a907f 
…ircuit-breaker behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaynaldM RaynaldM

Labels
Autumn'24 Autumn 2024 release Configuration Ocelot feature: Configuration feature A new feature proposal Proposal for a new functionality in Ocelot QoS Ocelot feature: Quality of Service small effort Likely less than a day of development effort.
Projects
None yet
Milestone
Autumn'24
Development

Successfully merging a pull request may close this issue.

#2080 Add new V8 params to fine-tune Polly's circuit-breaker behavior ThreeMammals/Ocelot
2 participants
@RaynaldM @raman-m