chore(docker-build) introdue multi-platform build for docker-gcloud-p… #348
Conversation
There was a problem hiding this comment.
Will this need some CI changes as well to this job since we're not passing in the --platform arg? It'd be awesome if the existing CI job could produce images for both platforms!
| "linux/amd64") gcloud_arch=x86_64 ;; \ | ||
| "linux/arm64") gcloud_arch=ARM ;; \ | ||
| esac \ | ||
| && curl -O https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-sdk-378.0.0-linux-${gcloud_arch}.tar.gz \ |
There was a problem hiding this comment.
So unfortunately specifying the gcloud version here breaks the guarantee of this image (https://github.com/TheKevJames/tools/tree/master/docker-gcloud-pubsub-emulator#gcloud-pubsub-emulator) which is that we want to auto-build a new image whenever the gcloud sdk gets updated (which is currently done via dockerhub triggers -- since google/cloud-sdk is the base image, dockerhub can be set to autobuild whenever that gets pushed.
We'll need to think of some way to have the same behaviour now that we're building the sdk manually. Two approaches which I could think might work would be:
- always install the latest version and setup a CI job to run on a, say, daily basis which pushes the
:latesttag, or - (preferred, but maybe harder?) move the gcloud sdk version tag to some location where Renovate (which is already enabled for this repo) can update it, then rely on the existing CI jobs / docker pushes to handle things.
|
Closing and tracking here |
…ubsub-emulator
used following command to test it locally:
It took
4m 56sto build both architecture versions locally on my machine :)Todo: