update react imports to easy react upgrade #7347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoran995
force-pushed
the
react-imports
branch
from
6a9473e
to
20cd04e
Compare
zoran995
force-pushed
the
react-imports
branch
from
20cd04e
to
f0b5a74
Compare
zoran995
commented
Nov 29, 2024
| @@ -126,6 +126,7 @@ export const ShareUrl = forwardRef< | |||
| id="share-url" | |||
| rounded={rounded} | |||
| onCopy={(text) => | |||
| // eslint-disable-next-line react/prop-types | |||
There was a problem hiding this comment.
for some reason, prop-types lint doesn't like forwardRef, suggestion to look into those after upgrade
zoran995
commented
Nov 29, 2024
| @@ -113,6 +113,7 @@ const SidePanelButton = forwardRef<HTMLButtonElement, SidePanelButtonProps>( | |||
| <Button | |||
| primary | |||
| ref={ref} | |||
| // eslint-disable-next-line react/prop-types | |||
zoran995
commented
Nov 29, 2024
| const ButtonWithRef = forwardRef<HTMLButtonElement, ButtonProps>( | ||
| (props, ref) => <Button {...props} buttonRef={ref} /> | ||
| ); | ||
| ButtonWithRef.displayName = "Button"; |
There was a problem hiding this comment.
same as above, just different lint rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Small step toward #6538
Run
upgrade-react-importscodemod to update react imports so they can work in react 17/18. Partially supersedes #7051.Don't worry about merge conflicts first PR is only changes by codemod so it is easy to recreate
Test me
Tested locally
yarn build-for-nodeandyarn gulp build. All tests passes. Running the app locally worksChecklist
doc/.