fix(omi): missing tag name when redefining

Tencent · Apr 1, 2024 · b5c1c39 · b5c1c39
1 parent f6d85b4
commit b5c1c39
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/packages/omi/package.json b/packages/omi/package.json
@@ -1,6 +1,6 @@
 {
   "name": "omi",
-  "version": "7.6.6",
+  "version": "7.6.7",
   "scripts": {
     "start": "vite",
     "dev-vite": "vite",

diff --git a/packages/omi/src/define.ts b/packages/omi/src/define.ts
@@ -4,13 +4,14 @@
  * @param ctor - The constructor function for the custom element.
  */
 export function define(tagName: string, ctor: CustomElementConstructor): void {
+  // 重复定义也需要挂载 tagName，防止重复定义时候被使用没有 tagName 当作函数
+  Object.defineProperty(ctor, 'tagName', { value: tagName, writable: false })
   if (customElements.get(tagName)) {
     console.warn(
       `Failed to execute 'define' on 'CustomElementRegistry': the tag name "${tagName}" has already been used with this registry`,
     )
     return
   }
-  Object.defineProperty(ctor, 'tagName', { value: tagName, writable: false })
   customElements.define(tagName, ctor)
 }
 

diff --git a/packages/omi/src/index.ts b/packages/omi/src/index.ts
@@ -19,4 +19,4 @@ export { Signal } from 'reactive-signal'
 export { css } from './css-tag'
 export { mixin, globalCSS } from './options'
 export { registerDirective } from './directive'
-export const version = '7.6.6'
+export const version = '7.6.7'