You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm expecting to get the full original picture when importing with quality set to 100. However I get a highly compressed image in return (~500KB compressed vs ~7MB original).
This is because of the compression done in GMGridViewController when writing the image to file: // setting compression to a low value (high compression) impact performance, but not actual img quality if ( ![ UIImageJPEGRepresentation(imageToDisplay, 0.2f) writeToFile:filePath atomically:YES ] ) { return; }
To me the comment is not true as any compression affects image quality. It might not be much but artefacts can be visible upon compression which is not what I expect.
The correct code is commented out a few lines above but I don't know why. Could someone explain? Otherwise I can suggest a PR to use the quality option given as input as the compression rate.
The text was updated successfully, but these errors were encountered:
I'm expecting to get the full original picture when importing with quality set to 100. However I get a highly compressed image in return (~500KB compressed vs ~7MB original).
This is because of the compression done in GMGridViewController when writing the image to file:
// setting compression to a low value (high compression) impact performance, but not actual img quality if ( ![ UIImageJPEGRepresentation(imageToDisplay, 0.2f) writeToFile:filePath atomically:YES ] ) { return; }
To me the comment is not true as any compression affects image quality. It might not be much but artefacts can be visible upon compression which is not what I expect.
The correct code is commented out a few lines above but I don't know why. Could someone explain? Otherwise I can suggest a PR to use the quality option given as input as the compression rate.
The text was updated successfully, but these errors were encountered: