Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition when spawning git processes for autograding #208

Closed
meffmadd opened this issue Feb 29, 2024 · 0 comments
Closed

Race condition when spawning git processes for autograding #208

meffmadd opened this issue Feb 29, 2024 · 0 comments
Labels
bug Something isn't working service Issue related to grader-service
Milestone

Comments

@meffmadd
Copy link
Member

Describe the bug
The bug is caused by the tornado Subprocess.wait_for_exit class: tornadoweb/tornado#3364
https://github.com/TU-Wien-dataLAB/Grader-Service/blob/baaaca0da029c881a01423a34f5b1d5f6620dae0/grader_service/autograding/local_grader.py#L440

I noticed this when testing autograding in the Celery workers where it would hang on git init.

This could also affect the git server:
https://github.com/TU-Wien-dataLAB/Grader-Service/blob/baaaca0da029c881a01423a34f5b1d5f6620dae0/grader_service/handlers/git/server.py#L48

I switched to Popen for the Celery branch, which is a drop-in replacement.

@meffmadd meffmadd added bug Something isn't working service Issue related to grader-service labels Feb 29, 2024
@meffmadd meffmadd added this to the 0.4.2 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working service Issue related to grader-service
Projects
None yet
Development

No branches or pull requests

2 participants