Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sharelink to search results #38

Open
rampraa opened this issue Mar 13, 2023 · 2 comments
Open

Implement sharelink to search results #38

rampraa opened this issue Mar 13, 2023 · 2 comments
Labels
feature request New feature or request

Comments

@rampraa
Copy link

rampraa commented Mar 13, 2023

In the current implementation, performing a search keeps the URL in the browser address bar static. So there is no way to share search results with another user. Requesting a way that updates the browser URL when a search is done, so that the entire search result can be sent over to another user. This is also useful if a bunch of registers following a certain pattern needs to be added to any documentation - this will allow users to add a single link with the search param instead of adding URL for each matching register.

@amykyta3
Copy link
Member

Thanks for filing this.
Currently the search page is actually an overlay over the existing page, so constantly changing the URL as you type in a query would be a little awkward.

Instead, what if I add a "share results" button?
Similar to the heading anchor links in the main content pages, clicking it would transform the browser navigation bar's URL to include the search query.

@amykyta3 amykyta3 added the feature request New feature or request label Mar 14, 2023
@rampraa
Copy link
Author

rampraa commented Mar 14, 2023

I see the issue with constantly changing URL since the search is an incremental search. Share results is a good solution to this. Thanks!

@amykyta3 amykyta3 changed the title Allow search via browser address bar. Implement sharelink to search results Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants