Update ModCraftTreeLinkingNode.cs #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add info that ModCraftTreeLinkingNode.AddTabNode(string nameID) does not set language lines Add check if AddModdedCraftingNode(string moddedTechTypeName) fails to find the moddedTechType
Metious
requested changes
Sep 26, 2023
Co-authored-by: Metious <[email protected]>
Metious
approved these changes
Sep 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only place I can find for tab nodes to be added without their language lines being set is when you only pass the ID and don't give it any display text at all.
Meaning that if your using that method you need to set the language lines yourself.
Changes made in this pull request
Breaking changes