Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same string keys multiple times #247

Open
cosmoscalibur opened this issue Jan 10, 2018 · 5 comments
Open

Same string keys multiple times #247

cosmoscalibur opened this issue Jan 10, 2018 · 5 comments

Comments

@cosmoscalibur
Copy link
Contributor

I see that many string keys string keys are multiple times in Caps, nocaps and ALLCAPS forms when string translation is the same. Is that necessary?
Because maintenance is more easy if the same translation string is only in one string key, use only one version could be a good option.

@Ivshti
Copy link
Member

Ivshti commented Jan 17, 2018

where is that? could be by mistake

@cosmoscalibur
Copy link
Contributor Author

cosmoscalibur commented Jan 17, 2018

For example in en-US.json. Some repeated translation strings are:

"TYPE_series": "Series",
"TYPE_series_PL": "Series",
"WEBSITE_TYPE_series_PL": "Series",
"INTRO_TASTE_COMEDY": "Comedy",
"Comedy": "Comedy",
"COMEDY": "Comedy",
"INTRO_TASTE_MUSIC": "Music",
"Music": "Music",
"MUSIC" : "Music",
"ADDONS": "Add-ons",
"WEBSITE_ADD_ONS": "Add-ons",
"INTRO_TASTE_HELP_US": "Help us learn more about you.",
"HELP_LEARN_MORE": "Help us learn more about you.",
"WEBSITE_CREATE_AN_ADDON": "Create an add-on",
"WEBSITE_ADDONS_CREATE": "Create an add-on",

And because this is the template for all you can see in more files.

@cosmoscalibur
Copy link
Contributor Author

Hi @Ivshti , also FAQ13 and FAQ18 are the same.

@cosmoscalibur
Copy link
Contributor Author

"WEBSITE_LINK_ADDON_SDK" is a duplicate object key.

@robertlluberes
Copy link
Contributor

Hi @Ivshti

I would like to work in this issue, how will be the correct way?.

I think that with these one that have the same key I can just delete one and put the other in uppercase, but what about with those one that have diferentts key?

Same key, same value:

"Music": "Music",
"MUSIC" : "Music",

Result:

"Music": "Music",

"MUSIC" : "Music",

Diferentt key, but same value:

"WEBSITE_CREATE_AN_ADDON": "Create an add-on",
"WEBSITE_ADDONS_CREATE": "Create an add-on",

Result:
?

What should I do in the last case?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants