Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest.config.key conflicts with reserved keyword "key". #263

Open
megadrive opened this issue Feb 27, 2024 · 3 comments
Open

Manifest.config.key conflicts with reserved keyword "key". #263

megadrive opened this issue Feb 27, 2024 · 3 comments

Comments

@megadrive
Copy link

megadrive commented Feb 27, 2024

Using "key" as an object key can lead to issues as it's a reserved keyword. TypeScript threw this up for me as an error. Rather than "key", another word should be used.

The reference in docs: https://github.com/Stremio/stremio-addon-sdk/blob/master/docs/api/responses/manifest.md#config-format

@jaruba
Copy link
Member

jaruba commented Feb 27, 2024

i propose length

@megadrive
Copy link
Author

I'm assuming you're joking, but why not id?

@jaruba
Copy link
Member

jaruba commented Feb 27, 2024

the addon configuration properties do no impact the addon sdk in any way, key is just used as an example, it can be changed to secretKey in the docs / example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants