Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .sdf assumption in GAIA #39

Open
timj opened this issue Sep 2, 2014 · 1 comment
Open

Remove .sdf assumption in GAIA #39

timj opened this issue Sep 2, 2014 · 1 comment

Comments

@timj
Copy link
Member

timj commented Sep 2, 2014

With commit ed5ae8d GAIA no longer assumes .sdf in the C and Fortran code. The TCL code is full of .sdf though and this needs to be cleaned up. Not sure how best to refactor the code at the moment (Tcl interface to dat_par.h? Tcl library that at least defines the file extension in a single place in GAIA?). @pwdraper how would you approach it?

This would be relevant if someone is writing an HDS emulation library on top of HDF5 and that person thinks it would be confusing to continue to call the files .sdf.

@pwdraper
Copy link
Member

pwdraper commented Sep 3, 2014

The obvious way to handle this in Tcl is to use a global variable. It would be easy to add this into the Gaia package init section, see the gaia/generic/Gaia.C file (in fact there is a Hds_Init section that looks like they would be better places to put this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants