Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The JPEG detection does not seem to work reliably #26

Open
timj opened this issue Mar 3, 2014 · 2 comments
Open

The JPEG detection does not seem to work reliably #26

timj opened this issue Mar 3, 2014 · 2 comments
Assignees
Labels

Comments

@timj
Copy link
Member

timj commented Mar 3, 2014

OS X builds do not seem to be detecting the JPEG library properly. The test should either determine if the library is installed and not build it, or else build the private Starlink JPEG. This causes problems on OS X where the JPEG can come from multiple different locations and if you do a build with homebrew it won't work with MacPorts. The solution, at least on Mac, may be to trigger the third party build of JPEG regardless of the existence of the library in the system.

@timj timj assigned grahambell and sfgraves and unassigned grahambell Mar 3, 2014
@timj timj added the bug label Apr 4, 2014
@timj
Copy link
Member Author

timj commented Oct 24, 2014

clang on Yosemite no longer seems to search /usr/local/. This triggers the JPEG build ok but then basic OS X tools start failing because DYLD_LIBRARY_PATH is set (see #1). Either we need to fix all the linking to remove the need for setting the search path or else we need to fix JPEG detection on OS X by simply linking against the ImageIO framework (-framework ImageIO might work but I haven't tested it). This would require a little extra checking in the configure scripts -- I'm actually surprised there aren't pre-canned autoconf macros for OS X framework detection).

@sfgraves
Copy link
Member

If I'm fixing up the binaries and .dylibs so we don't have to set a DYLD_LIBRARY_PATH, then I think the best way to solve this issue is to a) always build libjpeg on Mac OSX (at least when distributing) and then b) not set DYLD_LIBRARY_PATH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants