Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add virtual host property to RabbitMQ sensor #13

Open
dasilva opened this issue Feb 22, 2019 · 2 comments · May be fixed by #24
Open

Add virtual host property to RabbitMQ sensor #13

dasilva opened this issue Feb 22, 2019 · 2 comments · May be fixed by #24
Labels
enhancement help wanted

Comments

@dasilva
Copy link

dasilva commented Feb 22, 2019 •
edited
Loading

Hi,

I would like to suggest extending the message queue sensor to support virtual host configuration.
Ex:
sensor_config:
host: "rabbitmq"
vhost: "dev"
username: "developer"
password: "developer"
rabbitmq_queue_sensor:
queues:
- "sample_queue"
deserialization_method: "json"

A simple change on queues_sensor.py will handle this improvement.

++ self.vhost = self._config['sensor_config']['vhost']
++ connection_params = pika.ConnectionParameters(host=self.host, credentials=credentials, virtual_host=self.vhost)

Thank you,

Luciano
@blag
Copy link
Contributor

blag commented Feb 22, 2019

Hey @dasilva, would you be interested in writing a pull request that implements this?

You would be the best person to write the pull request because it sounds like you have a system you can test it against.

If you need any help writing a PR, feel free to ask a question here, or in the PR once you get going.

@dasilva
Copy link
Author

dasilva commented Feb 25, 2019

Sure, I will do.

@0xliam 0xliam linked a pull request Jan 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add virtual host connection params into RabbitMQQueueSensor 0xliam/stackstorm-rabbitmq
2 participants
@dasilva @blag