Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests pulling from remote cluster-stacks repository #14

Closed
3 tasks
janiskemper opened this issue Oct 4, 2023 · 1 comment
Closed
3 tasks
Assignees
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling Sprint Reykjavik Sprint Reykjavik (2023, cwk 50+51)

Comments

@janiskemper
Copy link
Member

/kind feature

Describe the solution you'd like
Add integration tests that use an actual remote cluster-stacks Git repository (e.g. SovereignCloudStack/cluster-stacks). These tests should ensure that all cluster stacks release assets are downloaded and processed successfully.

They do not have to test all functionality that can be tested just as well with local unit tests using envtest (#9).

This test requires a new folder in internal/controllers/test/integration and a new setup with controllers that defines the properties of the Reconcilers as needed (e.g. an actual Github client instead of a fake one in the unit tests).

** Important note: **
This requires a Github token, otherwise the CI will run into rate limits quickly. We should add a new token that allows to read the cluster-stacks repository.

Acceptance criteria:

  • Have tests for all utility functions in pkg folder where it makes sense to test
  • Add a new Make target to trigger integration tests
  • Add a new workflow to Github actions and set the environment variables accordingly
@janiskemper
Copy link
Member Author

Completed in #19

@github-project-automation github-project-automation bot moved this from Backlog to Done in Sovereign Cloud Stack Dec 19, 2023
@jschoone jschoone added Container Issues or pull requests relevant for Team 2: Container Infra and Tooling Sprint Reykjavik Sprint Reykjavik (2023, cwk 50+51) labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling Sprint Reykjavik Sprint Reykjavik (2023, cwk 50+51)
Projects
Archived in project
Development

No branches or pull requests

2 participants