Add repro for S6678 #9552
Merged
Add repro for S6678 #9552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned martin-strecker-sonarsource and unassigned sebastien-marichal
martin-strecker-sonarsource
requested changes
Jul 24, 2024
analyzers/tests/SonarAnalyzer.Test/TestCases/UsePascalCaseForNamedPlaceHolders.cs
Show resolved
Hide resolved
github-actions
bot
assigned sebastien-marichal and unassigned martin-strecker-sonarsource
There was a problem hiding this comment.
Had to create to support @$ and $$$ syntax available in C# 8 & C# 11.
|
|
github-actions
bot
assigned martin-strecker-sonarsource and unassigned sebastien-marichal
| { | ||
| logger.LogDebug($@"{nameof(Repro_9545)} filter: {{number}}", number); // Compliant - FN | ||
| logger.LogDebug(@$"{nameof(Repro_9545)} filter: {{number}}", number); // Compliant - FN | ||
| logger.LogDebug($$"""{{nameof(Repro_9545)}} filter: {number}""", number); // Compliant - FN |
There was a problem hiding this comment.
This is a bit surprising. It actually should raise given that implementation looks into interpolated string text portions. Nevermind. It is documented now.
martin-strecker-sonarsource
approved these changes
Jul 25, 2024
github-actions
bot
assigned sebastien-marichal and unassigned martin-strecker-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro for #9545