Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S6931 FN: Route starting with ~ character #9409

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Fix S6931 FN: Route starting with ~ character #9409

merged 2 commits into from
Jun 5, 2024

Conversation

zsolt-kolbay-sonarsource
Copy link
Contributor

Fixes #9002

pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...tests/SonarAnalyzer.Test/TestCases/AspNet/RouteTemplateShouldNotStartWithSlash.AspNetCore.vb Outdated Show resolved Hide resolved
@zsolt-kolbay-sonarsource @pavel-mikula-sonarsource
Add extra line
1cb0a92 
Co-authored-by: Pavel Mikula <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource merged commit a2657bf into master Jun 5, 2024
26 checks passed
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource deleted the Zsolt/S6931-FN-tilde-character branch June 5, 2024 15:21
@CristianAmbrosini
Copy link
Contributor

CristianAmbrosini commented Jun 6, 2024 •
edited
Loading

Peach validation
Lost: /
Added: 14 TP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix S6931 FN: Route templates starting with ~/
3 participants
@zsolt-kolbay-sonarsource @CristianAmbrosini @pavel-mikula-sonarsource