Refactor LVA and fix S1854 FP #5529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-mikula-sonarsource
changed the title
pavel-mikula-sonarsource
force-pushed
the
Pavel/LVA-Refactor
branch
from
21b561c
to
e694fc7
Compare
pavel-mikula-sonarsource
changed the base branch from
Pavel/LVA-NEstedFinally
to
master
analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/RoslynLiveVariableAnalysis.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/RoslynLiveVariableAnalysis.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/RoslynLiveVariableAnalysis.cs
Show resolved
Hide resolved
csaba-sagi-sonarsource
suggested changes
Apr 1, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5527 description for motivation for this refactoring. There was a design issue that doesn't scale anymore in LVA.
Before:
PredecessorsandSuccessorswere computed independently for each block. On the fly. This required synchronization between these two methods to provide good results in loop scenarios.The implementation wasn't completely symetrical.
After:
We compute each branch once and store it so it can be reused. We compute
Successorsfor each block and storePredecessorsandSuccessorsfrom this pair. Ensuring that the graph will always be symmetrical in both directions.Sice effect
Fixes #4949
because the old implementation wasn't completely symetrical.