Fix S1854 FPs: Improve catch block links

[pavel-mikula-sonarsource]

Similar to #4948

Roslyn LVA needs to be updated for better predecessors/successors computation.

catch should link to all blocks in try to propagate LiveIn through the loop.

public void TryReturns_Loop()
{
    var counter = 0;
    while (counter < 5)
    {
        counter++;  // Noncompliant FP related to LVA
        try
        {
            SomethingThatCanThrow();
            return;
        }
        catch (TimeoutException)
        {
            // Continue loop to the next try
        }
    }
}

[jairbubbles]

I had a similar FP on my side, I'm pasting my example but I'm pretty sure it's the same:

private static string ReadWithRetry(string filePath, int maxRetryCount = 3)
{
    int count = 0;
    while (count++ < maxRetryCount) // S1854 Remove this useless assignment to local variable 'count'
    {
        try
        {
            return File.ReadAllText(filePath);
        }
        catch (Exception)
        {
            Thread.Sleep(100);
        }
    }

    return String.Empty;
}