Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the "valid.xml" OpenCover test case #4038

Open
andrei-epure-sonarsource opened this issue Feb 9, 2021 · 1 comment
Open

Fix the "valid.xml" OpenCover test case #4038

andrei-epure-sonarsource opened this issue Feb 9, 2021 · 1 comment
Labels
Area: SQ Plugin Java plugin related issues. Type: Tests Add or modify individual UTs, ITs and Peach, not framework

Comments

@andrei-epure-sonarsource
Copy link
Contributor

The current test case for a valid OpenCover report ("valid.xml") creates noise when being parsed.

OpenCover parser: invalid start line for file (ID '3', path 'MyLibrary\Adder.cs', indexed as ...

This should not happen for valid XML. We should regenerate this test case. But bear in mind the OpenCover versioning. We need to use also an older open cover format which doesn't have the "fileid" in the SequencePoint attribute. Otherwise, we'll lose coverage.

Alternatively, we can decide to drop this "RefFile" UID fallback feature - must investigate in which OpenCover version it got dropped (if in any).
@andrei-epure-sonarsource andrei-epure-sonarsource added Area: SQ Plugin Java plugin related issues. Type: Tooling Tools make us productive. labels Feb 9, 2021
@pavel-mikula-sonarsource pavel-mikula-sonarsource added Type: Tests Add or modify individual UTs, ITs and Peach, not framework and removed Type: Tooling Tools make us productive. labels Jul 9, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource added Sprint: Hardening Fix FPs/FNs/improvements Sprint: SQ Plugin Hardening and removed Sprint: Hardening Fix FPs/FNs/improvements labels Jul 23, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource added this to the 9.31 milestone Jul 23, 2024
@Tim-Pohlmann Tim-Pohlmann self-assigned this Jul 30, 2024
@Tim-Pohlmann Tim-Pohlmann mentioned this issue Jul 30, 2024
Closed
@Tim-Pohlmann Tim-Pohlmann removed the Sprint: Hardening Fix FPs/FNs/improvements label Aug 1, 2024
@Tim-Pohlmann
Copy link
Contributor

I updated priority and effort and moved this back to the backlog.

@Tim-Pohlmann Tim-Pohlmann removed their assignment Aug 1, 2024
@Tim-Pohlmann Tim-Pohlmann removed this from the 9.31 milestone Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: SQ Plugin Java plugin related issues. Type: Tests Add or modify individual UTs, ITs and Peach, not framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the "valid.xml" OpenCover test case SonarSource/sonar-dotnet
5 participants
@Tim-Pohlmann @andrei-epure-sonarsource @pavel-mikula-sonarsource @mary-georgiou-sonarsource @zsolt-kolbay-sonarsource