Razor mappings: Ensure we check if the mapped span is valid (#9305)

SonarSource · May 21, 2024 · c225c8e · c225c8e
1 parent 1d041d4
commit c225c8e
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/analyzers/src/SonarAnalyzer.Common/Metrics/MetricsBase.cs b/analyzers/src/SonarAnalyzer.Common/Metrics/MetricsBase.cs
@@ -42,14 +42,13 @@ public abstract class MetricsBase
         public ISet<int> CodeLines =>
             tree.GetRoot()
                 .DescendantTokens()
-                .Where(x => !IsEndOfFile(x))
-                .Select(x => x.GetLocation().GetMappedLineSpan())
-                .Where(IsInSameFile)
+                .Select(GetMappedLineSpan)
+                .Where(x => x is not null)
                 .SelectMany(
                     x =>
                     {
-                        var start = x.StartLinePosition.GetLineNumberToReport();
-                        var end = x.EndLinePosition.GetLineNumberToReport();
+                        var start = x.Value.StartLinePosition.GetLineNumberToReport();
+                        var end = x.Value.EndLinePosition.GetLineNumberToReport();
                         return Enumerable.Range(start, end - start + 1);
                     })
                 .ToHashSet();
@@ -119,6 +118,14 @@ protected bool IsInSameFile(FileLinePositionSpan span) =>
         private IEnumerable<SyntaxNode> FunctionNodes =>
             tree.GetRoot().DescendantNodes().Where(IsFunction);
 
+        private FileLinePositionSpan? GetMappedLineSpan(SyntaxToken token) =>
+            !IsEndOfFile(token)
+            && token.GetLocation().GetMappedLineSpan() is { IsValid: true } mappedLineSpan
+            && (!GeneratedCodeRecognizer.IsRazor(token.SyntaxTree) || mappedLineSpan.HasMappedPath)
+            && IsInSameFile(mappedLineSpan)
+                ? mappedLineSpan
+                : null;
+
         private static void CategorizeLines(string line, int lineNumber, ISet<int> noSonar, ISet<int> nonBlank)
         {
             if (line.Contains("NOSONAR"))