Rails 6.1 #193
Open
Rails 6.1 #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smart Listing supports three states for sorting: 1. "asc": ascending order using a given column of a table 2. "desc": descending order using a given column of a table 3. "": default ordering for the table (e.g. if you want to order by "name" by default, but allow sorting on "created at", you'd want this state to return the table to its default order) When attempting to use the default ordering _as requested by the user_ Smart Listing would construct a query attribute like this: `"fulfillment_order_sources.name "` (note extra space at the end). Rails 6.0 was okay with this, 6.1 is not.
Rails 6.0 is okay with something like this:
"fulfillment_order_sources.name"
Rails 6.1 is not. You have to parse this first.
Co-authored-by: Justin Giancola <[email protected]>
|
@jherdman Have you found any way to use smart_listing in Rails 6? |
|
My employer has a fork here https://github.com/PrecisionNutrition/smart_listing. I absolutely do not recommend using our fork. We will change it as need be, but are intending on moving away from Smart Listing ASAP. You're free to lift the code out into your own fork, or even attempt to have it upstreamed should that be possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.