Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configured hidden class and popover_destroy command are not applied correctly #187

Open
Katsari opened this issue Jul 6, 2020 · 0 comments

Comments

@Katsari
Copy link

Katsari commented Jul 6, 2020

I noticed the new item action does not work when the hidden class in SmartListing initializer is changed.

When clicking the new item button, the configured hidden class should be removed from new-item-placeholder and added to new-item-action but the class that gets applied to new-item-action is still hidden and not the configured one. Also, it is applied to the placeholder but not removed after click.

Something similar happens when the popover_destroy command is modified like this:

  config.constants :bootstrap_commands, {
    popover_destroy: 'dipsose', # Bootstrap 4 requries dipsose instead of destroy
  }

I had to rewrite the showPopover method to use dispose to get it to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant