Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow users to join global rooms by suffixing URL with /custom-room-id #620

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

allow users to join global rooms by suffixing URL with /custom-room-id #620

wants to merge 1 commit into from

Commits on Feb 26, 2024

  1. allow users to join global rooms by suffixing URL with /custom-room-id 

    simple solution:
snapdrop.net/       -> room by IP
snapdrop.net/foo -> room foo, no matter what IP

invalidates a previously faulty PR:
SnapDrop#288

and provides an alternative: specify the `snapdrop_mount` if you app is
deployed on a different URL than `/`. it's not a "hack" to substitute
the path via a command, like the home assistant guys used to do [1] --
it's normal, because you're doing a non-standard deployment. i just
simplified how it'd need to be done now, while for everyone else, the
easy room switching becomes available.

[1] deftdawg/homeassistant-addons@29f99c1
    @kiprasmel
    kiprasmel committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    8f2685d View commit details
    Browse the repository at this point in the history