Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in syntax highlighting for Ocaml #204

Open
jeroenpelgrims opened this issue Oct 31, 2018 · 2 comments
Open

Error in syntax highlighting for Ocaml #204

jeroenpelgrims opened this issue Oct 31, 2018 · 2 comments
Labels
bug Something isn't working e/toplevel

Comments

@jeroenpelgrims
Copy link

jeroenpelgrims commented Oct 31, 2018

Example: https://sketch.sh/s/h7mXF4K6jtQXY1cflQJHhT/

As you can see in the example, when using the double quote character in a character literal the syntax highlighting starts to freak out.
It seems to think I've opened a string but not closed it.

@matthiaskern matthiaskern added the bug Something isn't working label Nov 6, 2018
@matthiaskern
Copy link
Collaborator

This would require changes to

"'": function(stream, state) {

Related: #195

@thangngoc89
Copy link
Member

@matthiaskern This is related to OCaml syntax highlighting
so I belive this could be brought up to codemirror's maintainer attention or we can fork the ocaml syntax highlighter into Sketch's repo

@thangngoc89 thangngoc89 added e/bucklescript Bucklescript engine related issues e/toplevel labels Jul 31, 2019
@jchavarri jchavarri removed the e/bucklescript Bucklescript engine related issues label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working e/toplevel
Projects
None yet
Development

No branches or pull requests

4 participants