Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Stop all extractors to free resources #120

Open
dprevost-LMI opened this issue Oct 20, 2024 · 2 comments · May be fixed by #119
Open

[FEATURE] Stop all extractors to free resources #120

dprevost-LMI opened this issue Oct 20, 2024 · 2 comments · May be fixed by #119

Comments

@dprevost-LMI
Copy link
Contributor

dprevost-LMI commented Oct 20, 2024

In a scenario where we want to use the audio player to load several audio messages for different conversations and where navigation between conversations is required only to show one conversation at a time, we need an efficient way to load the audio message but also to cancel nearly everything if we switch to another conversation.

In the above scenario, when navigating away from all those audio players being played or having their waveform extracted, we need to stop them. Otherwise, opening more and more conversations in a short period will bust resources (promises, players, extractors).

Here's an example of stopping all the extractors. Of course, we should typically not stay on that screen but load new audio messages, but for the testing, what is shown in the video was sufficient.

Screen.Recording.2024-10-19.at.9.13.22.PM.mov

See this PR: #119

@kuldip-simform kuldip-simform linked a pull request Oct 23, 2024 that will close this issue
@kuldip-simform
Copy link
Contributor

We have released a new version 2.1.2. Please use that, and if the issue still persists, reopen or create a new issue.

@dprevost-LMI
Copy link
Contributor Author

dprevost-LMI commented Nov 19, 2024

@kuldip-simform: This is not merged yet. Can we reopen it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants