Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker user guide to the README file of the repository #295

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

dcodoni
Copy link
Contributor

@dcodoni dcodoni commented Oct 31, 2024

  • brief intro
  • how to build/pull an image
  • how to run a container on personal computer
  • how to use containers on HPC systems: singularity

Current situation

Currently svFSIplus is compiled in a Docker image, publicly available. Moreover, dockerfiles are also available to build images containing just the environment to compile svFSIplus with both Trilinos and PETSc, and images that includes the precompiled svFSIplus. We do not have any documentation/user guide on how to build Docker images or on how to run a container on a local machine or HPC system.

Release Notes

I added a section in the main README file on Docker which briefly explain how to build images from the provided dockerfiles and how to run simulations using the containers provided or built by the users, on a local machine and on HPC systems.

Documentation

Last section of README file is updated.

Testing

No testing required.

Code of Conduct & Contributing Guidelines

* brief intro
* how to build/pull an image
* how to run a container on personal computer
* how to use containers on HPC systems: singularity
@dcodoni dcodoni requested review from ktbolt and mrp089 October 31, 2024 01:17
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
* moved the docker section rigth after the introduction
* Added an example on how to run a test case inside a container
* more detailed on the architecture added
* made the job script more readable
* moved details on how to build the image from dockerfiles in Docker/README.md
@mrp089 mrp089 merged commit 8fd8191 into SimVascular:main Nov 1, 2024
5 checks passed
@mrp089
Copy link
Member

mrp089 commented Nov 1, 2024

Thank you, @dcodoni! This will save SO much time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants