Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bytesafe] Add support for PostgreSQL sslmode parameter #45

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

conclusionlogic
Copy link

This PR introduces the following changes to the config.yaml template and values.yaml supporting [email protected]:

  • Creates and configures the DB_SSLMODE environment variable using the config.yaml template.
  • Sets the default value for sslmode to prefer using the .Values.postgresql.auth.sslmode and .Values.externalDatabase.sslmode parameters.
  • Bumps the default Chart version, appVersion, and tag values from 1.0.4 to 1.0.12

PS: This PR is built on top of changes introduced in #44

This commit introduces several changes to the `statefulSet.yaml` template to enhance readability and maintainability:
- Indentation has been corrected across various sections to ensure consistency and improve the visual hierarchy of the YAML structure.
- Conditional blocks for `statefulSet.labels`, `statefulSet.annotations`, `pod.labels`, and `pod.annotations` have been adjusted to include proper indentation and spacing, making it easier to distinguish between nested properties.
- The `serviceName` attribute under `spec` has been explicitly set to use the `bytesafe.fullname` template, ensuring clarity in service references.
- Added conditions to check the creation of a service account and set `automountServiceAccountToken` to true, which is crucial for environments where service accounts need automatic token mounting.
- Adjusted the handling of persistent volume claims to align with the enabled state of persistence and the presence of an existing claim, improving the logic flow and readability.
- Minor formatting adjustments have been made to the environment variables and their values to maintain uniformity in key-value assignments.
This commit introduces several changes to the `statefulSet.yaml` template to enhance readability and maintainability:
- Indentation has been corrected across various sections to ensure consistency and improve the visual hierarchy of the YAML structure.
- Conditional blocks for `statefulSet.labels`, `statefulSet.annotations`, `pod.labels`, and `pod.annotations` have been adjusted to include proper indentation and spacing, making it easier to distinguish between nested properties.
- The `serviceName` attribute under `spec` has been explicitly set to use the `bytesafe.fullname` template, ensuring clarity in service references.
- Added conditions to check the creation of a ServiceAccount and set `automountServiceAccountToken` to true as well as referenced the correct ServiceAccount name.
This commit introduces the following changes to `config.yaml` template and `values.yaml` file for [email protected]:
- Creates and configures DB_SSLMODE environment variable using `config.yaml` template
- Default value for `sslmode` set to `prefer` using `.Values.postgresql.auth.sslmode` and `.Values.externalDatabase.sslmode` parameters
- Bumps default Chart version, appVersion, tag values from 1.0.4 to 1.0.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant