From 3fd9a38687ad27a2cfcfe3f893136f5082a552b0 Mon Sep 17 00:00:00 2001
From: Nils Reichardt <me@nils.re>
Date: Fri, 1 Nov 2024 00:04:06 +0100
Subject: [PATCH] Fix race condition when joining a school class with courses
 (#1781)

As described in #1780, there was a bug where nothing happened after
selecting a course to join a class. I added some print statements to
understand the problem and found out that when pushing the
`_GroupJoinPage` page with `Navigator.push` multiple instances of the
`GroupJoinBloc` were created (~16 instances). This led to the problem
that when later accessing the `GroupJoinBloc` with
`BlocProvider.of(context)` a different bloc was returned than the one
used when entering the code.

Fixes #1780
---
 .../groups/group_join/group_join_page.dart    | 35 +++++++++++++------
 1 file changed, 25 insertions(+), 10 deletions(-)

diff --git a/app/lib/groups/group_join/group_join_page.dart b/app/lib/groups/group_join/group_join_page.dart
index 24b52767f..302e701d7 100644
--- a/app/lib/groups/group_join/group_join_page.dart
+++ b/app/lib/groups/group_join/group_join_page.dart
@@ -9,6 +9,7 @@
 import 'package:bloc_provider/bloc_provider.dart';
 import 'package:crash_analytics/crash_analytics.dart';
 import 'package:flutter/material.dart';
+import 'package:provider/provider.dart';
 import 'package:sharezone/main/application_bloc.dart';
 import 'package:sharezone/groups/src/widgets/contact_support.dart';
 import 'package:sharezone/support/support_page.dart';
@@ -21,30 +22,44 @@ import 'widgets/group_join_text_field.dart';
 /// Auf dieser Seite kann der Nutzer einen Sharecode eingeben oder QrCode scannen und
 /// dadurch einer Gruppe beitreten.
 Future<dynamic> openGroupJoinPage(BuildContext context) {
-  final api = BlocProvider.of<SharezoneContext>(context).api;
   return Navigator.push(
     context,
     MaterialPageRoute(
-      builder: (context) => BlocProvider(
-        bloc: GroupJoinBloc(api.connectionsGateway, getCrashAnalytics()),
-        child: const _GroupJoinPage(),
-      ),
+      builder: (context) => const _GroupJoinPage(),
       settings: const RouteSettings(name: _GroupJoinPage.tag),
     ),
   );
 }
 
-class _GroupJoinPage extends StatelessWidget {
+class _GroupJoinPage extends StatefulWidget {
   const _GroupJoinPage();
 
   static const tag = "group-join-page";
 
+  @override
+  State<_GroupJoinPage> createState() => _GroupJoinPageState();
+}
+
+class _GroupJoinPageState extends State<_GroupJoinPage> {
+  late GroupJoinBloc bloc;
+
+  @override
+  void initState() {
+    super.initState();
+    final api = BlocProvider.of<SharezoneContext>(context).api;
+    final analytics = context.read<CrashAnalytics>();
+    bloc = GroupJoinBloc(api.connectionsGateway, analytics);
+  }
+
   @override
   Widget build(BuildContext context) {
-    return const Scaffold(
-      appBar: GroupJoinAppBar(),
-      body: SafeArea(child: SingleChildScrollView(child: GroupJoinHelp())),
-      bottomNavigationBar: ContactSupport(),
+    return BlocProvider(
+      bloc: bloc,
+      child: const Scaffold(
+        appBar: GroupJoinAppBar(),
+        body: SafeArea(child: SingleChildScrollView(child: GroupJoinHelp())),
+        bottomNavigationBar: ContactSupport(),
+      ),
     );
   }
 }